Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge latest changes to feature branch #1623

Merged
merged 197 commits into from
Oct 23, 2024
Merged

Merge latest changes to feature branch #1623

merged 197 commits into from
Oct 23, 2024

Conversation

mukeshpanchal27
Copy link
Member

Please approve so we get the latest changes in feature branch.

westonruter and others added 30 commits August 16, 2024 17:15
@westonruter
Introduce methods to get minumum height of element
0a376c1
@westonruter
Set the min-height of an embed prior to it loading
8aa7e63
@westonruter
Set min-height on embed-wrapper instead of figure container
11f98f4
@westonruter
Use 500px as a better representation of an element that could be LCP
d7cc7cf
@westonruter
Add test for existing style manipulation
48e57e8
@westonruter
Add helper generator method to get all elements
0d285f2
@westonruter
Try using MutationObserve to watch for embed height changes
4778a3d
@westonruter
Use the more appropriate ResizeObserver instead of MutationObserver
1dbd4a1
@westonruter
Remove condition that breaks monitoring resizes of post embeds
a4bab7e
@westonruter
Introduce client-side Optimization Detective extensions and move Embe…
5f0cdbe 
…d Optimizer JS into one
@westonruter
Override clientBoundingRect once embed has loaded
0ba2d6e
@westonruter
Move jsdoc types to types.d.ts for reuse
5f4189d
@westonruter @swissspidy
Send URL metric when leaving the page
bf2b3c5 
This is an iteration on top of #1098

Co-authored-by: swissspidy <[email protected]>
@westonruter
Use boundingClientRect instead of intersectionRect in get_all_element…
b9bad0d 
…_minimum_heights
@westonruter
Eliminate timeout for disconneccting ResizeObsever
c6b02ec
@westonruter
Move extension initialization after idle callback
52a2260
@westonruter
Fix warning when prematurely applying buffered text replacements, esp…
edc52fa 
…ecially to end-of-body
@westonruter
Prepend min-height to style attribute instead of appending
820d66d
@westonruter
Avoid setting meta attribute when value unchanged
7864449
@westonruter
Allow viewport_height to be specified in sample URL metric
7b01495
@westonruter
Add get_all_elements_positioned_in_any_initial_viewport() and is_elem…
9c8799b 
…ent_positioned_in_any_initial_viewport() methods to OD_URL_Metrics_Group_Collection
@westonruter
Add fetchpriority=low to occluded elements in initial viewport
c573175
@westonruter
Update auto-sizes tests to specify out-of-viewport rects
67c6557
@westonruter @swissspidy
Use object spread
def2aab 
Co-authored-by: swissspidy <[email protected]>
@westonruter
Merge branch 'trunk' of https://github.com/WordPress/performance into…
cd9a618 
… add/embed-optimizer-min-height-reservation
@thelovekesh
Add Image_Prioritizer_Video_Tag_Visitor class
fadc0fe
@thelovekesh
Add video-tag-visitor to be loaded
a6c9592
@thelovekesh
Add video tag visitor in the OD visitors
138b2b8
@thelovekesh
Update checking for crossorigin attrs on img and video tags
03fc900
@westonruter
Merge branch 'trunk' into add/embed-optimizer-min-height-reservation
02c4fd9
westonruter and others added 14 commits October 21, 2024 10:47
@westonruter
Account for plugin dependencies when storing relevant plugin info
f385a43
@westonruter @swissspidy
Fix array structure
7e2768e 
Co-authored-by: swissspidy <[email protected]>
@westonruter
Merge pull request #1611 from WordPress/release/3.5.0
cb1d472 
Post 3.5.0 release merge
@westonruter
Merge branch 'trunk' of https://github.com/WordPress/performance into…
cf0d3f2 
… fix/storing-standalone-plugin-info
@westonruter
Merge pull request #1613 from WordPress/fix/storing-standalone-plugin…
70ca5b5 
…-info

Account for plugin dependencies when storing relevant plugin info
@westonruter
Merge pull request #1614 from WordPress/release/3.5.1
e95df5f 
Post 3.5.1 release merge
@dependabot
Bump phpstan/phpstan from 1.12.6 to 1.12.7
41f033f 
Bumps [phpstan/phpstan](https://github.com/phpstan/phpstan) from 1.12.6 to 1.12.7.
- [Release notes](https://github.com/phpstan/phpstan/releases)
- [Changelog](https://github.com/phpstan/phpstan/blob/2.0.x/CHANGELOG.md)
- [Commits](phpstan/phpstan@1.12.6...1.12.7)

---
updated-dependencies:
- dependency-name: phpstan/phpstan
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot
Bump phpstan/php-8-stubs from 0.4.2 to 0.4.3
d7bd29c 
Bumps [phpstan/php-8-stubs](https://github.com/phpstan/php-8-stubs) from 0.4.2 to 0.4.3.
- [Release notes](https://github.com/phpstan/php-8-stubs/releases)
- [Commits](phpstan/php-8-stubs@0.4.2...0.4.3)

---
updated-dependencies:
- dependency-name: phpstan/php-8-stubs
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@westonruter
Merge pull request #1619 from WordPress/dependabot/composer/phpstan/p…
9ab5e48 
…hp-8-stubs-0.4.3

Bump phpstan/php-8-stubs from 0.4.2 to 0.4.3
@westonruter
Merge pull request #1618 from WordPress/dependabot/composer/phpstan/p…
a9f91e6 
…hpstan-1.12.7

Bump phpstan/phpstan from 1.12.6 to 1.12.7
@dependabot
Bump @wordpress/scripts from 30.1.0 to 30.3.0
d646c2a 
Bumps [@wordpress/scripts](https://github.com/WordPress/gutenberg/tree/HEAD/packages/scripts) from 30.1.0 to 30.3.0.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/scripts/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/scripts)

---
updated-dependencies:
- dependency-name: "@wordpress/scripts"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@mukeshpanchal27
Merge pull request #1620 from WordPress/dependabot/npm_and_yarn/wordp…
e5daec8 
…ress/scripts-30.3.0

Bump @wordpress/scripts from 30.1.0 to 30.3.0
@dependabot
Bump @wordpress/env from 10.9.0 to 10.10.0
a89ada8 
Bumps [@wordpress/env](https://github.com/WordPress/gutenberg/tree/HEAD/packages/env) from 10.9.0 to 10.10.0.
- [Release notes](https://github.com/WordPress/gutenberg/releases)
- [Changelog](https://github.com/WordPress/gutenberg/blob/trunk/packages/env/CHANGELOG.md)
- [Commits](https://github.com/WordPress/gutenberg/commits/@wordpress/[email protected]/packages/env)

---
updated-dependencies:
- dependency-name: "@wordpress/env"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@mukeshpanchal27
Merge pull request #1621 from WordPress/dependabot/npm_and_yarn/wordp…
356fa9b 
…ress/env-10.10.0

Bump @wordpress/env from 10.9.0 to 10.10.0
@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release skip changelog PRs that should not be mentioned in changelogs labels Oct 22, 2024
@mukeshpanchal27 mukeshpanchal27 marked this pull request as ready for review October 22, 2024 15:12
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: westonruter <[email protected]>
Co-authored-by: thelovekesh <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: felixarntz <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@mukeshpanchal27 mukeshpanchal27 merged commit 614b1a5 into feature/1511-incorporate-layout-constraints-from-ancestors Oct 23, 2024
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixarntz felixarntz felixarntz approved these changes

@westonruter westonruter westonruter approved these changes

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein adamsilverstein is a code owner

@pbearne pbearne Awaiting requested review from pbearne pbearne is a code owner

@joemcgill joemcgill Awaiting requested review from joemcgill joemcgill is a code owner

@thelovekesh thelovekesh Awaiting requested review from thelovekesh thelovekesh is a code owner

@swissspidy swissspidy Awaiting requested review from swissspidy

Assignees
No one assigned
Labels
Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mukeshpanchal27 @westonruter @felixarntz @thelovekesh @swissspidy @devansh016